On Mon, Mar 1, 2021 at 1:01 PM Alex White <alexanderjwh...@gmail.com> wrote: > > This patch set updates the covoar tool to allow it to work with the > outputs of the current build system. It includes various fixes and > improvements needed to successfully produce coverage reports for the > following BSP configurations: griscv-sis, leon3-sis, pc-qemu, > xilinx_zynqmp, and xilinx_zynq_a9_qemu. > > Here is a link to the final coverage reports that I got for the five > configurations mentioned above: > https://ftp.rtems.org/pub/rtems/people/joel/coverage/coverage-2021-02-28/ > > > Alex White (22): > tester: Update to support new build system > tester: Add coverage variants for a few BSPs > covoar/TargetBase: Update branchInstructions variable name > covoar/Target_i386: Add NOP patterns > covoar/Target_arm: Add THUMB branch instructions > covoar: Add aarch64 target > covoar/CoverageReaderQEMU: Fix infinite loop > covoar/TargetBase: Fix QEMU branch info > covoar: Fix DWARF reading > dwarf: Fix get_source > covoar: Account for build path change > covoar: Fix NOP execution marking > covoar: Handle periods in symbols from objdump > covoar/reports: Add new statistics to summary > coverage/reports: Improve formatting and clarity > coverage/reports: Share common JS and CSS in reports > covoar: Fix null pointer dereference > covoar: Add option to create named objdumps > covoar: Catch exceptional case > covoar: Allow symbols from objdump to be skipped > covoar: Fix overflow of high PC address > covoar/Reports: Fix empty branch report >
Can you split this patch set up in some logical groups? I see: tester configuration changes dwarf bug fixes covoar bug fixes covoar improvements/additions coverage reports improvements It will be easier to review and merge them in smaller chunks that are logically organized together. > rtemstoolkit/rld-dwarf.cpp | 13 +- > rtemstoolkit/rld-dwarf.h | 5 + > rtemstoolkit/rld-process.cpp | 12 + > rtemstoolkit/rld-process.h | 9 + > tester/covoar/CoverageMapBase.cc | 10 + > tester/covoar/CoverageMapBase.h | 4 + > tester/covoar/CoverageReaderQEMU.cc | 11 +- > tester/covoar/DesiredSymbols.cc | 48 +++- > tester/covoar/DesiredSymbols.h | 34 ++- > tester/covoar/ExecutableInfo.cc | 95 ++++++- > tester/covoar/ObjdumpProcessor.cc | 145 ++++++++--- > tester/covoar/ReportsBase.cc | 80 ++++-- > tester/covoar/ReportsHtml.cc | 243 +++++++++--------- > tester/covoar/ReportsText.cc | 76 +++--- > tester/covoar/SymbolTable.cc | 12 +- > tester/covoar/TargetBase.cc | 14 +- > tester/covoar/TargetBase.h | 4 +- > tester/covoar/TargetFactory.cc | 2 + > tester/covoar/Target_aarch64.cc | 100 +++++++ > tester/covoar/Target_aarch64.h | 77 ++++++ > tester/covoar/Target_arm.cc | 70 +++-- > tester/covoar/Target_i386.cc | 73 +++--- > tester/covoar/Target_lm32.cc | 12 +- > tester/covoar/Target_m68k.cc | 98 +++---- > tester/covoar/Target_powerpc.cc | 56 ++-- > tester/covoar/Target_riscv.cc | 22 +- > tester/covoar/Target_sparc.cc | 66 ++--- > tester/covoar/app_common.cc | 10 + > tester/covoar/app_common.h | 1 + > tester/covoar/covoar.cc | 135 +++++----- > tester/covoar/wscript | 1 + > tester/rt/coverage.py | 63 +++-- > tester/rtems/testing/bsps/a53_qemu-cov.ini | 41 +++ > tester/rtems/testing/bsps/griscv-sis-cov.ini | 4 +- > tester/rtems/testing/bsps/leon3-qemu-cov.ini | 4 +- > tester/rtems/testing/bsps/leon3-sis-cov.ini | 4 +- > tester/rtems/testing/bsps/pc-qemu-cov.ini | 42 +++ > .../testing/bsps/xilinx_zynq_a9_qemu-cov.ini | 41 +++ > .../rtems/testing/bsps/xilinx_zynqmp-cov.ini | 41 +++ > tester/rtems/testing/coverage/symbol-sets.ini | 91 +++---- > 40 files changed, 1327 insertions(+), 542 deletions(-) > create mode 100644 tester/covoar/Target_aarch64.cc > create mode 100644 tester/covoar/Target_aarch64.h > create mode 100644 tester/rtems/testing/bsps/a53_qemu-cov.ini > create mode 100644 tester/rtems/testing/bsps/pc-qemu-cov.ini > create mode 100644 tester/rtems/testing/bsps/xilinx_zynq_a9_qemu-cov.ini > create mode 100644 tester/rtems/testing/bsps/xilinx_zynqmp-cov.ini > > -- > 2.27.0 > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
