On Mon, Aug 23, 2021 at 9:29 PM Chris Johns <chr...@rtems.org> wrote:
>
> Hi,
>
> Could you please explain this file?
>
> Where is the source?
>
> Why would we allow a binay blob into the tester like this?

Hi Chris,

Running MicroBlaze tests on QEMU requires an appropriate DTB file to pass to 
QEMU via the "-hw-dtb" flag. There does not appear to be a way to pass the 
device tree source to QEMU.

This particular DTB comes from Xilinx as part of their KCU105 BSP. It seems 
most sensible to store it next to the tester configuration similar to the other 
device tree files in that directory (psim-device-tree, etc.).

I realize that this is a binary file and the other device tree files in 
tester/rtems/testing/bsps are not, but it seems that this needs to live 
alongside the BSP configuration so that it can be referenced by kcu105_qemu.ini.

>
> This seems specific to a set up or a BSP and not the tester. I am not
> comfortable with this approach. Have alternative approaches have you 
> considered?

I am not aware of another way that would ensure consistency with the tester 
configuration. We could require that a user obtain the DTB from elsewhere and 
copy it to the correct directory, but that seems a lot more involved than just 
including the needed file and would be more difficult to keep consistent with 
any future changes that might be needed.

Thanks,

Alex

>
> Chris
>
> On 24/8/21 4:46 am, Alex White wrote:
> > ---
> >  tester/rtems/testing/bsps/kcu105.dtb      | Bin 0 -> 15256 bytes
> >  tester/rtems/testing/bsps/kcu105_qemu.ini |  38 ++++++++++++++++++++++
> >  2 files changed, 38 insertions(+)
> >  create mode 100644 tester/rtems/testing/bsps/kcu105.dtb
> >  create mode 100644 tester/rtems/testing/bsps/kcu105_qemu.ini
> >
> > diff --git a/tester/rtems/testing/bsps/kcu105.dtb 
> > b/tester/rtems/testing/bsps/kcu105.dtb
> > new file mode 100644
> > index 
> > 0000000000000000000000000000000000000000..998e8c03b74d8d9ddc82b5f6fa53242415abbd84
> > GIT binary patch
> > literal 15256
> >
>
> Chris
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to