[PATCH 04/35] libfdt: Use VALID_INPUT for FDT_ERR_BADSTATE checks

[Sebastian Huber]

From: Simon Glass <s...@chromium.org>

This error indicates a logic bug in the code calling libfdt, so VALID_DTB
is not really the right check. Update it to use VALID_INPUT instead.

Signed-off-by: Simon Glass <s...@chromium.org>
Suggested-by: David Gibson <da...@gibson.dropbear.id.au>
Message-Id: <20200302190255.51426-4-...@chromium.org>
Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
---
 cpukit/dtc/libfdt/fdt.c    | 2 +-
 cpukit/dtc/libfdt/fdt_sw.c | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/cpukit/dtc/libfdt/fdt.c b/cpukit/dtc/libfdt/fdt.c
index 4419204a86..c28fcc1157 100644
--- a/cpukit/dtc/libfdt/fdt.c
+++ b/cpukit/dtc/libfdt/fdt.c
@@ -33,7 +33,7 @@ int32_t fdt_ro_probe_(const void *fdt)
                }
        } else if (fdt_magic(fdt) == FDT_SW_MAGIC) {
                /* Unfinished sequential-write blob */
-               if (fdt_size_dt_struct(fdt) == 0)
+               if (!can_assume(VALID_INPUT) && fdt_size_dt_struct(fdt) == 0)
                        return -FDT_ERR_BADSTATE;
        } else {
                return -FDT_ERR_BADMAGIC;
diff --git a/cpukit/dtc/libfdt/fdt_sw.c b/cpukit/dtc/libfdt/fdt_sw.c
index 352193c0a7..26759d5dfb 100644
--- a/cpukit/dtc/libfdt/fdt_sw.c
+++ b/cpukit/dtc/libfdt/fdt_sw.c
@@ -12,7 +12,7 @@
 
 static int fdt_sw_probe_(void *fdt)
 {
-       if (!can_assume(VALID_DTB)) {
+       if (!can_assume(VALID_INPUT)) {
                if (fdt_magic(fdt) == FDT_MAGIC)
                        return -FDT_ERR_BADSTATE;
                else if (fdt_magic(fdt) != FDT_SW_MAGIC)
@@ -41,7 +41,7 @@ static int fdt_sw_probe_memrsv_(void *fdt)
        if (err)
                return err;
 
-       if (!can_assume(VALID_DTB) && fdt_off_dt_strings(fdt) != 0)
+       if (!can_assume(VALID_INPUT) && fdt_off_dt_strings(fdt) != 0)
                return -FDT_ERR_BADSTATE;
        return 0;
 }
@@ -67,7 +67,8 @@ static int fdt_sw_probe_struct_(void *fdt)
        if (err)
                return err;
 
-       if (fdt_off_dt_strings(fdt) != fdt_totalsize(fdt))
+       if (!can_assume(VALID_INPUT) &&
+           fdt_off_dt_strings(fdt) != fdt_totalsize(fdt))
                return -FDT_ERR_BADSTATE;
        return 0;
 }
-- 
2.31.1

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel