Hello Sebastian, I have also reviewed the other changes that we now have since the original BSP patch, and it looks like our current queue for Zynq RPU is empty.
We are curious to see which changes/rework for RPU you are preparing. Thanks, Stanislav ________________________________ Von: Sebastian Huber <sebastian.hu...@embedded-brains.de> Gesendet: Dienstag, 19. März 2024 11:50 An: Stanislav Pankevich <stanis...@reflexaerospace.com>; devel@rtems.org <devel@rtems.org> Betreff: Re: bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer Counter clock driver [Sie erhalten nicht häufig E-Mails von sebastian.hu...@embedded-brains.de. Weitere Informationen, warum dies wichtig ist, finden Sie unter https://aka.ms/LearnAboutSenderIdentification ] Hello Stanislav, that is a nice coincidence. I started to work with this BSP last week and I also fixed this issue, but I had some other patches in the queue. I reworked this driver a bit. I will check in your patch first. On 19.03.24 10:54, Stanislav Pankevich wrote: > Dear RTEMS developers, > > Here is a follow-up patch to our previous work on the Zynq US+ RPU BSP. > > In fact, we had fixed this issue a few months ago but didn't find a good > time to upstream it since then. > > P.S. It is great to see that the migration to GitLab is happening. > > Thanks, > Stanislav > > --- > > Author: Stanislav Pankevich <stanis...@reflexaerospace.com> > Date: Tue Mar 19 10:34:57 2024 +0100 > > bsps: xilinx-zynqmp-rpu: fix the integer truncation in Triple Timer > Counter clock driver > We observed a strange behavior of the 1Hz timer when running cFS on > Zynq RPU. After some investigation, we reduced the error to the > truncation issue. This patch fixes the issue. > > diff --git a/bsps/shared/dev/clock/xil-ttc.c > b/bsps/shared/dev/clock/xil-ttc.c > index 2c47684045..5121773a6f 100644 > --- a/bsps/shared/dev/clock/xil-ttc.c > +++ b/bsps/shared/dev/clock/xil-ttc.c > @@ -126,7 +126,7 @@ static void > zynqmp_ttc_clock_driver_support_initialize_hardware(void) > /* Setup match register to generate tick IRQ */ > ttc_clock_instance.irq_match_interval = > - (uint32_t) ((frequency * microsec_per_tick) / 1000000); > + (uint32_t) (((uint64_t)frequency * microsec_per_tick) / 1000000); > XTtcPs_WriteReg(BSP_SELECTED_TTC_ADDR, XTTCPS_MATCH_0_OFFSET, > ttc_clock_instance.irq_match_interval); > /* Clear interupts (clear on read) */ > > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
