Hi Maxim, On 11/01/2010 01:45 PM, Maxim Sobolev wrote: > Dear Anca, > > Sorry for the delay. Basically your patch combines two distinct > features into the same package: > > 1. Ability to send the notification to a remote host via TCP/IP. > > 2. Ability to have more than one hosts to report to. > > While both features make perfect sense, the specific implementation in > your patch had had several problems. The biggest issue was abusing > single notification worker thread for maintaining several independent > connections. The right approach would be to start separate thread per > each connection. Therefore, I've re-implemented (1) to support TCP/IP > notifications and the code is now in master branch of the official Git > repository. You are welcome to check it out, test and let me know if > something is not working properly. > Thank you very much for improving the implementation and adding it in the public code. Indeed, the connection through tcp might get the thread blocked in case the connection is low or the destination not responding, so different threads for each notification thread is a good idea. We will take the code and test it and let you know. > As for the (2), this feature needs more work and will be added later > on. I need to figure out a way to manage multiple notification worker > threads and also provide some ways to secure this configuration. Your > patch removes the security check that prevents requesting notification > to an address not specifically provisioned in the RTPproxy configuration. > > Please let me know if you would want to work on (2) based on the > suggested approach above. > Yes, we can work on this. One solution to keep the security check could be allowing -n parameter to take a list of socket definitions so that we can put there all the sockets for all the SIP servers that can be require notification. We will also look into how to manage multiple notification threads.
Thanks and regards, -- Anca Vamanu www.voice-system.ro _______________________________________________ Devel mailing list [email protected] http://lists.rtpproxy.org/mailman/listinfo/devel
