Hi Eugeniy, Eugeniy Paltsev wrote, > Hi Waldemar, > > On Wed, 2016-06-15 at 20:32 +0200, Waldemar Brodkorb wrote: > > Hi Eugeniy, > > Eugeniy Paltsev wrote, > > > > > > > > Hello, > > > I'm running uclibc-1.0.15 testsuite on ARC and see "tst-ethers" > > > fails. > > > From what I may see "tst-ethers" test requires /etc/ethers to exist > > > and > > > to have host "teeth", otherwise it fails. > > > This test passed on ARC and other architectures, as I can see at > > > http:/ > > > /tests.embedded-test.org/uClibc-ng/1.0.15/ , so I'm wondering if > > > there's some dependency we need to have in place for this test to > > > pass > > > successfully? > > It is just added into the buildsystem making all the toolchains and > > cross-compiling the qemu images. > > > > > > > > Or, maybe, we should create /etc/ethers file with host "teeth" at > > > the > > > beginning of the test, if they does not exists? > > As a user might run the test as non-root I would rather suggest > > we may add a check if a /etc/ethers exist and if not print an > > error message. > > > > What do you think? > > best regards > > Waldemar > > > > Sorry had to resend as I had a typo in my sending address. > I think we can do something like that: > If /etc/ethers exist - launch test, > otherwise - print warning message like "test doesn't launch cause file > /etc/ethers doesn't exist. You should create this file manually." and > return 0 (because it isn'y uClibc problem). > But we also need to check, if /etc/ethers containts "teeth" host. > Otherwise we will not know real reason of "ether_hostton" function > fails: is it uClibc problem or just /etc/ethers doesn't contain "teeth" > host.
May be the first check is enough, I don't think so much people are using the test suite, so we shouldn't overcomplicate this. If the test fails, I think the tester will look into the code. Can you provide a patch to implement the first check if the file exist? Or do you think checking the content of /etc/ethers is required, too? best regards Waldemar _______________________________________________ devel mailing list [email protected] http://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
