Hello,
I've done a quick review of your patches
* DNSRAND_FORCE_SIMPLECOUNTERMODE needs to be configurable, have a look
at how it's done in extra/Configs/Config.in so that users don't need to
actually modify the source code to tweak this feature while building
their toolchain.
* is it a good idea to actually call srandom from the libc itself?
What about if the user already called srandom on some precise seed and
expects it to stay that way? (For instance in order to have a
reproducible random sequence)
What about if the user provided seed was of better "quality"?
* Only do the open("/dev/urandom") if urand_fd != -1 in dnsrand_setup().
* Try to respect the same coding style as the remaining parts of the file
* declare variables at beginning of the function or at the beginning
of the code block { }
* do not put "return" on the same line as the "if", put it on next
line with proper indentation
* put spaces around % binary operator
How is this done in musl? in glibc?
Maybe we can have a look and take inspiration from there.
Yann
Le 05/05/2022 à 18:51, [email protected] a écrit :
Hi Waldemar,
Will send you the squashed single patch. Please do cross check it once just to
be sure that I havent overlooked anything obvious.
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
_______________________________________________
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
