Dr Andrew C Aitchison writes:
> With Roland's fix, mkfontscale generates encodings.dir files
> containing the string (null), ie with lines like:
>
> big5-0 (null)(null)large/big5.eten-0.enc
> big5.eten-0 (null)large/big5.eten-0.enc
> viscii1.1-1 (null)./viscii1.1-1.enc.gz
> adobe-symbol (null)./adobe-symbol.enc.gz
>
> The following diff seems to remove the nulls;
> any idea whether this is the right solution ?
Juliusz?
> --------------------------------------------
> diff -u -r1.8 mkfontscale.c
> --- mkfontscale.c 2003/06/30 16:52:57 1.8
> +++ mkfontscale.c 2003/07/01 11:58:19
> @@ -1203,7 +1203,7 @@
> continue;
>
> for(name = names; *name; name++) {
> - if(fullname[0] != '/') {
> + if(encodingPrefix && fullname[0] != '/') {
> char *n;
> n = dsprintf("%s%s", encodingPrefix, fullname);
> if(n == NULL) {
> --------------------------------------------
>
> What sort of checking was done before replaceing mkfontdir with
> mkfontscale ?
I had the impression that this had been tested to some extend.
Otherwise I wouldn't have committed the fixes.
Appearantly is had not been tested thoroughly.
>
> Is there a realistic prospect of testing and fixing this
> properly within say a week ?
> If not, I'd like to revert to building the real mkfontdir app and
> having a build option to use one or the other when making XFree86.
>
Yes, if we don't have an improved version by the end of the week
I will revert this.
Having build options for all kinds of experimental stuff doesn't
sound like a realistic solution. Better to have some sandbox
separate from the main tree.
Egbert.
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel
