I found two things:
1) In ucs2any.c the libgen.h header is included only to provide basename, while a local definition of basename is provided for those platforms that don't have it. However, libgen.h is still included even on those platforms that define NEED_BASENAME. Thus, the build is broken on platforms that don't have libgen.h, regardless of whether NEED_BASENAME is defined or not.
The #include <libgen.h> needs to be protected with #ifndef NEED_BASENAME, like so:
#ifndef NEED_BASENAME #include <libgen.h> #endif
2) The zitoa function is defined statically but it isn't used within ucs2any.c. Is there any reason it should be included if it isn't in use?
Harold
Matthieu Herrb wrote:
Hi,
It seems to me that the C langage version of ucs2any.pl developped by Ben Collver and other NetBSD developpers is now stable enough to be included in XFree86.
I've put a patch against the current XFree86 CVS version at
<http://www.xfree86.org/~herrb/ucs2any.diffs> for those who'd like to
review it. I plan to commit that in the next days if no problems are
found.
Matthieu _______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
_______________________________________________ Devel mailing list [EMAIL PROTECTED] http://XFree86.Org/mailman/listinfo/devel
