Ah yes. I skimmed over shmstr.h too quickly and assumed INT16 instead
of CARD16 for the source coords.

I'll try this now.

Alan.

On Wed, Dec 17, 2003 at 03:08:03PM -0800, Mark Vojkovich wrote:
>    I don't think it's as bad as you think.  It looks to me like
> this comes about due to a difference in the Shm protocol.  Going
> against convention, xShmPutImageReq has an unsigned value for the
> src X and Y location.  All other primitive have signed values.
> I think the correct behavior is probably to clamp the source X and
> Y in ProcShmPutImage function to the unsigned 15 bit coordinate 
> system.  Can somebody try that to see if it fixes the problem?
> 
>                       Mark.
> 
> 
> On Wed, 17 Dec 2003, Alan Hourihane wrote:
> 
> > Having looked at Bugzilla #978 it shows that it's very easy to crash
> > the Xserver when using out-of-bounds coordinates that get mixed up when
> > passing in int's that get converted to short's during the client->server
> > conversation. 
> > 
> > Seeing as PutImage gets pushed through the CopyArea path, I'm sure
> > the same problem can happen with the core protocol request for XCopyArea()
> > too (and possibly others).
> > 
> > There's obvious ways to fix this, but I'm keen to hear others views...
> > 
> > Alan.
> > _______________________________________________
> > Devel mailing list
> > [EMAIL PROTECTED]
> > http://XFree86.Org/mailman/listinfo/devel
> > 
> 
> _______________________________________________
> Devel mailing list
> [EMAIL PROTECTED]
> http://XFree86.Org/mailman/listinfo/devel
_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to