On Thu, 18 Mar 2004, Lee Olsen wrote:

> The rendition driver probe routine is freeing usedChips in the wrong place.
> It's allocated inside an if xf86GetPciVideoInfo and freed outside the block,
> so systems without a pci bus free an uninitialized pointer. Here's a diff of
> the proposed chasnge.

> *** rendition.c    Thu Mar 18 14:03:27 2004
> --- rendition.c.orig    Sat Jan 10 20:03:16 2004
> ***************
> *** 354,361 ****
>           foundScreen=TRUE;
>           }
>           }
> -         xfree(usedChips);
>       }
>       return foundScreen;
>   }
>
> --- 354,361 ----
>           foundScreen=TRUE;
>           }
>           }
>       }
> +     xfree(usedChips);
>       return foundScreen;
>   }
>

deviceSections also isn't being xfree()'d when this is run on a PCI-less
system.  Both are now corrected in the HEAD branch.  Thanks for pointing
this out.

Marc.

+----------------------------------+-----------------------------------+
|  Marc Aurele La France           |  work:   1-780-492-9310           |
|  Computing and Network Services  |  fax:    1-780-492-1729           |
|  352 General Services Building   |  email:  [EMAIL PROTECTED]          |
|  University of Alberta           +-----------------------------------+
|  Edmonton, Alberta               |                                   |
|  T6G 2H1                         |     Standard disclaimers apply    |
|  CANADA                          |                                   |
+----------------------------------+-----------------------------------+
XFree86 developer and VP.  ATI driver and X server internals.

_______________________________________________
Devel mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/devel

Reply via email to