Author: tim.bunce
Date: Thu Oct 16 08:11:15 2008
New Revision: 520
Modified:
trunk/HACKING
trunk/NYTProf.xs
Log:
Move error check from NYTP_printf to NYTP_close.
Add note about source code access.
Modified: trunk/HACKING
==============================================================================
--- trunk/HACKING (original)
+++ trunk/HACKING Thu Oct 16 08:11:15 2008
@@ -296,3 +296,7 @@
Could add an extra attribute that measures time spent when recursing
(based on
CvDEPTH(cv)) wich would be 0 for subs that didn't recurse (a handy
boolean) and
could be subtracted from the inclusive time to get the 'outer' inclusive
time.
+
+Could add ::Data method to write source code for each fid into
$dir/nytprof_src_$fid.txt
+OR, probably better, add method to return source code array ref, that
defaults to returning
+the embeded source array, if available, else hunts for and loads current
source file.
Modified: trunk/NYTProf.xs
==============================================================================
--- trunk/NYTProf.xs (original)
+++ trunk/NYTProf.xs Thu Oct 16 08:11:15 2008
@@ -684,9 +684,6 @@
retval = vfprintf(ofile->file, format, args);
va_end(args);
- if (retval < 0)
- croak("error writing to profile data file: %s", strerror(errno));
-
return retval;
}
@@ -760,6 +757,9 @@
#endif
Safefree(file);
+
+ if (ferror(raw_file))
+ warn("There was an error writing to the profile data file\n");
if (discard) {
/* close the underlying fd first so any buffered data gets
discarded
--~--~---------~--~----~------------~-------~--~----~
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.
Group hosted at: http://groups.google.com/group/develnytprof-dev
Project hosted at: http://perl-devel-nytprof.googlecode.com
CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf
To post, email: [email protected]
To unsubscribe, email: [EMAIL PROTECTED]
-~----------~----~----~----~------~----~------~--~---
