On Thu, Oct 16, 2008 at 10:18:03AM -0700, Jan Dubois wrote:
>
> On Thu, 16 Oct 2008, Tim Bunce wrote:
>
> > Thanks. Applied.
> >
> > Want a commit bit? Just send me a google-registered email address.
>
> Sure, that will make things easier when I look at the remaining issues:
>
> [EMAIL PROTECTED]
You're in now.
> Do I have to run everything through perlcritic and/or indent before checking
> things in?
I haven't tried perlcritic on it yet. The perl code is not great.
I'm inching my way towards getting rid of Devel::NYTProf::Reader
by expanding the object model but meanwhile there are inconsistencies
and general oddness to be found all over the place.
$ perlcritic . | wc -l
50
Umm. Probably best if I work my way through those.
As for indent, there are 'perltidy' and 'ctidy_bcpp' targets in the
makefile but I'd recommend you don't use them. The code was tidied not
long ago. Just stick to no-tabs and 4-space-indent and we'll be fine.
(There are vim settings for those embedded in most of the files.
Freel free to add equivalents for whatever editor you're using.)
Tim.
--~--~---------~--~----~------------~-------~--~----~
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.
Group hosted at: http://groups.google.com/group/develnytprof-dev
Project hosted at: http://perl-devel-nytprof.googlecode.com
CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf
To post, email: [email protected]
To unsubscribe, email: [EMAIL PROTECTED]
-~----------~----~----~----~------~----~------~--~---
