Author: tim.bunce
Date: Tue Dec  9 08:00:18 2008
New Revision: 646

Modified:
    trunk/HACKING
    trunk/lib/Devel/NYTProf/Util.pm

Log:
Cosmetic tweaks to Devel/NYTProf/Util.pm
Add a couple of thoughts to HACKING


Modified: trunk/HACKING
==============================================================================
--- trunk/HACKING       (original)
+++ trunk/HACKING       Tue Dec  9 08:00:18 2008
@@ -343,3 +343,10 @@

  Class::MOP should update %DB::sub (if $^P & 0x10 set) when it creates  
methods.
  Sub::Name should do same (extracting the file and line from the  
ANON[...:...])
+
+Add refs so a string eval fid can be related to its 'siblings' (other  
string
+eval fids from the same line in the 'parent' fid).
+
+Profile should report _both_ the 'raw original' filename (possibly  
relative)
+used by the application being profiled, plus an absolute filename  
determined
+ASAP (to avoid problems with scripts that chdir).

Modified: trunk/lib/Devel/NYTProf/Util.pm
==============================================================================
--- trunk/lib/Devel/NYTProf/Util.pm     (original)
+++ trunk/lib/Devel/NYTProf/Util.pm     Tue Dec  9 08:00:18 2008
@@ -44,7 +44,8 @@

  our @EXPORT_OK = qw(
      fmt_float
-    fmt_time fmt_incl_excl_time
+    fmt_time
+    fmt_incl_excl_time
      make_path_strip_editor
      strip_prefix_from_paths
      calculate_median_absolute_deviation
@@ -74,7 +75,7 @@

      # rewrite relative directories to be absolute
      # the logic here should match that in get_file_id()
-    my $abs_path_regex = $^O eq "MSWin32" ? qr,^\w:/, : qr,^/,;
+    my $abs_path_regex = ($^O eq "MSWin32") ? qr,^\w:/, : qr,^/,;
      for (@inc) {
          next if $_ =~ $abs_path_regex;    # already absolute
          $_ =~ s/^\.\///;   # remove a leading './'

--~--~---------~--~----~------------~-------~--~----~
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.

Group hosted at:  http://groups.google.com/group/develnytprof-dev
Project hosted at:  http://perl-devel-nytprof.googlecode.com
CPAN distribution:  http://search.cpan.org/dist/Devel-NYTProf

To post, email:  [email protected]
To unsubscribe, email:  [EMAIL PROTECTED]
-~----------~----~----~----~------~----~------~--~---

Reply via email to