On Wed, Jan 20, 2010 at 05:59:38PM +0000, Tim Bunce wrote:
> On Tue, Jan 19, 2010 at 12:04:58PM +0000, Nicholas Clark wrote:

> > I'm not sure if this is because they are all assuming golden results, and
> > I've just changed the ordering, or there is a more serious problem. My
> > assumption was that any "eval" filename that exists has a corresponding
> > real file to go with it, and that *that* file would get spotted later on
> > in the %DB::sub iteration. So I'm not sure what to do here. Skipping "eval"
> > filenames seems conceptually cleaner, but I don't understand *why* it causes
> > breakage.
> 
> Are you having fun yet? :)

I thought I was, but little did I know how much *more* fun awaited me.
Specifically, the current directory matters. These two produce different
results with/without the change

/home/nclark/Sandpit/snap5.9.x-v5.11.3-122-gd549c43/bin/perl5.11.3 -Iblib/lib 
-d:NYTProf t/test61-submerge.p
/home/nclark/Sandpit/snap5.9.x-v5.11.3-122-gd549c43/bin/perl5.11.3 
-I../blib/lib -d:NYTProf test61-submerge.p

because of hash key ordering in %DB::sub

> > So now I feel that I need to work out what the diff against all the test
> > results actually means.

> Go ahead. When life gets too short, and the results seems sane, I've
> done that myself many times before ;-)

The only differences in trace files are down to the expected changes of
various subs and ops in main:: now being mapped to the real *.p file rather
than one of the eval fake files, and in some cases resultant knock on effects
from different FID mappings.

But it sure makes a lot of diff "noise" in the file dumps and structure
changes.

I'm going home now - I'll fix things up tomorrow.

Nicholas Clark
-- 
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.

Group hosted at:  http://groups.google.com/group/develnytprof-dev
Project hosted at:  http://perl-devel-nytprof.googlecode.com
CPAN distribution:  http://search.cpan.org/dist/Devel-NYTProf

To post, email:  [email protected]
To unsubscribe, email:  [email protected]

Reply via email to