On Thu, Feb 04, 2010 at 03:53:53PM +0000, Nicholas Clark wrote:
> On Thu, Feb 04, 2010 at 10:59:16AM +0000, Tim Bunce wrote:
> > On Wed, Feb 03, 2010 at 01:49:22PM +0000, Nicholas Clark wrote:
> > > On Thu, Dec 17, 2009 at 09:13:44PM +0000, Tim Bunce wrote:
> 
> > > > In the code to finalize the file, output any attributes that only have a
> > > > single distinct value. Any with more that one...
> > > >     application: join with " and "
> 
> That busts the buffer limit on reading. I need to have a think about that.

Well, the buffer could be made larger :)

More usefully, it would be good if the final report could show
attributes from each of the files that were merged.
So perhaps attributes could include an index:
    $profile->attribute->[0]->{application}

The [0]'th element would be original attributes in the case of an
unmerged file. For a merged file they could be the "smart merged"
'summary' that you currently generate. The 'application' attribute
could then simply say something like "(merge of N files)".

Just a thought.

> > > In turn, those two aren't actually
> > > attributes - they're written as part of NYTP_TAG_PID_START and
> > > NYTP_TAG_PID_END. (Which makes sense, as it means that the profile format
> > > already copes with representing data from multiple runs.
> > 
> > An artifact from the days when forking was handled with multiple
> > processes locking and writing to the same file.
> 
> But a useful artefact.

True.

Another alternative would be to take some things that are currently
attributes and move them to become fields of NYTP_TAG_PID_START.

Tim.

-- 
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.

Group hosted at:  http://groups.google.com/group/develnytprof-dev
Project hosted at:  http://perl-devel-nytprof.googlecode.com
CPAN distribution:  http://search.cpan.org/dist/Devel-NYTProf

To post, email:  [email protected]
To unsubscribe, email:  [email protected]

Reply via email to