On Mon, Mar 08, 2010 at 09:28:50PM +0000, Nicholas Clark wrote: > On Mon, Mar 08, 2010 at 09:14:54PM +0000, Tim Bunce wrote: > > On Mon, Mar 08, 2010 at 01:56:20PM +0000, Nicholas Clark wrote: > > > > > > Right. That is the last thing that I committed. > > > > Great work Nicholas. All test pass here on assorted perls. > > I think I only tried on 2 or 3 different perls, but one is using g++ rather > than gcc, to try to keep me honest on the function pointers and static array > declarations. > > I think that it would be possible to further decouple the input reader routine > from NYTProf.xs by passing 3 (more) function pointers in (via its state > object) > - a logger function, a warner function, and a croaker function. That would > make it viable to move it to FileHandle.xs. However, it doesn't decouple it > from needing a perl runtime (yet. And I'm not sure how worth it, that sort of > further untangling is)
Might well be a YAGNI. We can leave it till the need arises. Looking thorough the new functions I see lots of places where they detect errors and return with some error value, but the code in NYTProf.xs rarely checks the value. Wouldn't it be better to just croak? > > Would you like me to make a dev release for cpantesters to chew on? > > Yes please. All being well, Devel-NYTProf-3.10_50 will be uploaded shortly. Tim. -- You've received this message because you are subscribed to the Devel::NYTProf Development User group. Group hosted at: http://groups.google.com/group/develnytprof-dev Project hosted at: http://perl-devel-nytprof.googlecode.com CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf To post, email: [email protected] To unsubscribe, email: [email protected]
