Revision: 1262
Author: [email protected]
Date: Tue Jun 1 06:18:12 2010
Log: Remove $eval_fid and $eval_line from the callbacks for time_block and
time_line.
Since callbacks were first implemented, both have always ever been 0,
because
the information is derived within the file loader, rather than being present
in the profile file. As we already have a flag day change in the callback
interface (sub_callers), it makes sense to also make this change now.
http://code.google.com/p/perl-devel-nytprof/source/detail?r=1262
Modified:
/trunk/NYTProf.xs
/trunk/bin/nytprofmerge
/trunk/lib/Devel/NYTProf/ReadStream.pm
=======================================
--- /trunk/NYTProf.xs Tue Jun 1 06:17:55 2010
+++ /trunk/NYTProf.xs Tue Jun 1 06:18:12 2010
@@ -4185,8 +4185,8 @@
{STR_WITH_LEN("VERSION"), "uu"},
{STR_WITH_LEN("ATTRIBUTE"), "33"},
{STR_WITH_LEN("COMMENT"), "3"},
- {STR_WITH_LEN("TIME_BLOCK"), "00uuuuu"},
- {STR_WITH_LEN("TIME_LINE"), "00uuu"},
+ {STR_WITH_LEN("TIME_BLOCK"), "uuuuu"},
+ {STR_WITH_LEN("TIME_LINE"), "uuu"},
{STR_WITH_LEN("DISCOUNT"), ""},
{STR_WITH_LEN("NEW_FID"), "uuuuuuS"},
{STR_WITH_LEN("SRC_LINE"), "uuS"},
@@ -4236,14 +4236,6 @@
while ((type = *arglist++)) {
switch(type) {
- case '0':
- {
- /* These really should go, but need a flag day change in
- documented callback API. */
- sv_setuv(cb_args[i], 0);
- XPUSHs(cb_args[i++]);
- break;
- }
case 'u':
{
unsigned int u = va_arg(args, unsigned int);
=======================================
--- /trunk/bin/nytprofmerge Tue Jun 1 06:17:33 2010
+++ /trunk/bin/nytprofmerge Tue Jun 1 06:18:12 2010
@@ -60,7 +60,7 @@
my %pending_subs;
sub _time_block_or_line {
- my ($tag, undef, undef, $ticks, $fid, $line, $block_line, $sub_line) =
@_;
+ my ($tag, $ticks, $fid, $line, $block_line, $sub_line) = @_;
my $is_line = $tag eq 'TIME_LINE';
confess("No mapping for $fid") unless defined $fids{$fid};
=======================================
--- /trunk/lib/Devel/NYTProf/ReadStream.pm Tue Jun 1 06:17:33 2010
+++ /trunk/lib/Devel/NYTProf/ReadStream.pm Tue Jun 1 06:18:12 2010
@@ -163,9 +163,9 @@
Files are represented by integers called 'fid' (File IDs) and this chunk
declares
the mapping between these numbers and file path names.
-=item TIME_BLOCK => $eval_fid, $eval_line, $ticks, $fid, $line,
$block_line, $sub_line
-
-=item TIME_LINE => $eval_fid, $eval_line, $ticks, $fid, $line
+=item TIME_BLOCK => $ticks, $fid, $line, $block_line, $sub_line
+
+=item TIME_LINE => $ticks, $fid, $line
A TIME_BLOCK or TIME_LINE chunk is output each time the execution of
the program leaves a statement.
--
You've received this message because you are subscribed to
the Devel::NYTProf Development User group.
Group hosted at: http://groups.google.com/group/develnytprof-dev
Project hosted at: http://perl-devel-nytprof.googlecode.com
CPAN distribution: http://search.cpan.org/dist/Devel-NYTProf
To post, email: [email protected]
To unsubscribe, email: [email protected]
