Quoting Daverdo <[EMAIL PROTECTED]>:

> Hello,
>
> I am new to nedit.  It is an excellent editor.  I have been using my own
> Motif editor for over 10 years.  I was attracted nedit's syntax
> highlighting and tags support.  Nedit is a very intuitive editor.

Glad you like it!

> I would like to make a suggestion.  I would like to change the
> background colors on the popup menu pushbuttons that I created.
> Unfortunately, they are all named "cmd".  A small change to userCmds.c
> will give each widget its own name, which will allow setting colors via
> a X resource file.
>
> The code is below...

Seems reasonable to me, though, at a glance, it seems you have an off-by-1
error if your name is too long (you copy up to size characters *then* add
a '\0' at the end). Another thing is the expression isalnum((int)*name).
If char is signed (I think it is/was(?) with Sun's compiler), this can
cause problems, especially with the old-fashioned macro implementation of
ctype.h. Better to use isalnum((unsigned char)*name) instead to be
explicit. You'll see that construct used elsewhere (but not systematically)
in nedit code.
>
> Opinions?

I for one will give it a whirl. Just out of interest, why do you want to
color these menu entries separately?

Tony
-- 
NEdit Develop mailing list - [email protected]
http://www.nedit.org/mailman/listinfo/develop

Reply via email to