On Saturday 29 December 2007 03:54:53 Thorsten Haude wrote: > * Ivan Skytte Jørgensen wrote (2007-10-13 13:54): > >I gave the I also gave it a spin with Flexelint 8.0w. It complains a lot, > > and I have included the most interesting warnings. ... > > Good work! I went through your list and found a number of open issues. > Please have a look at the patch at SF bug #1860273: > > https://sourceforge.net/tracker/index.php?func=detail&aid=1860273&group_id= >11005&atid=111005
I will have a look one of the following days. > >WindowInfo->fileFormat is declared int, but its content are the enum > >fileFormats from util/fileUtils.h This could be done in a nicer way. > > What do you suggest? If the contents is always one of the enumeration elements then the type of WindowInfo->fileFormat could be changed to "enum fileFormats". But that requires including a headerfile and I think there were a recursive include there... I admit: I forgot the reason I did not make a patch for it. > >selection.c:95-110 > > char *endptr; > > ... > > if (isdigit((unsigned char) *endptr ) ... > >Why the cast? > > To clear things up? I changed it into (int). Did you see my followup on this 2007-10-15 19:12? My conclusion was that the casts should be kept as-is. A cast to int will extend the sign and still cause problems on Solaris. Regards, Ivan -- NEdit Develop mailing list - [email protected] http://www.nedit.org/mailman/listinfo/develop
