Quoting Bert Wesarg <[EMAIL PROTECTED]>:
> This is my proposal for fixing several issues with the handling of compiled
> macro programs.
...
> If there are no objections, I commit this by the end of the week, plus my
> proposal B for SF: BUG#2074318, from here:
setupFrame() doesn't check the remaining space in the stack to see if the
call frame will fit. In my latest stuff, I just folded all stack frame
building into a routine, callSubroutineFromSymbol(), which uses the current
context so that the PUSH macros etc will do the check (I added a PUSH_CHECK
macro to allow checking for the function linkage space in one go). For
rewindFrame() checking is less important: all should be correct already.
Why not have it take a RestartData *context argument BTW?
setupFrame() also checks for a negative args count. That's an extension I
added for the named arguments/arguments array stuff. You shouldn't need it in
the code base (yet!).
Other than that, having these two functions defined close together is a very
sound idea. And it's good that the same operations aren't repeated 3 times
over (as in the current source base).
As for your 2074318 stuff, why not?
All in all, I'm for it. Does anyone else have anything to say? This would be
for the v5.6 ("L'Arlesienne") version, I suppose!
Tony
--
NEdit Develop mailing list - [email protected]
http://www.nedit.org/mailman/listinfo/develop
