On 8/7/16 10:44 PM, Toomas Soome wrote: > > One of the lessons learned by oracle was that you don’t want to just run > around trimming things - they did end up with adding minimal suggested amount > to trim, otherwise > the storage did suffer… I may be mistaken, but something like 1MB or so. > Another question is, the trim is not just about ssd, but also about thin > provisioned storage from arrays (where the excessive amount of small releases > can cause even more damage;)? > > Perhaps trim/autotrim could use pool property for minimal trim size (sorry, > havent had yet time to read into the review…).
That's in there already: zfs_trim_min_ext_sz (coincidentally, by default also set to 1MB) in zio.c. You can make it as aggressive or as passive as you like. The reason it's a kernel tunable, not a pool property, is because it's one of those "sharp edges" that are best not placed into or anywhere near administrators' hands. -- Saso ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
