On Thu, Dec 8, 2016 at 9:05 AM, Florentin Lefebvre <
[email protected]> wrote:
> Hello,
>
>
> I send this email on the ML to have some advices about the patch (I'm a
> newbie [image: 😃]).
>
>
> To store the logicalquotas values, i'm using zap, but maybe it's better to
> modify
> the stuct dsl_dataset {} or dsl_dir{} ?
>
ZAP is an on-disk structure, whereas dsl_dataset_t and dsl_dir_t structures
are in-memory only. So it depends on if you need the values to be
persisted. FYI, dsl_dataset_phys_t and dsl_dir_phys_t structures are
stored on disk, but we should not modify them if at all possible, to avoid
on-disk compatibility issues. New dataset-specific or dsl_dir-specific
on-disk state should be stored in the "zapified" dataset/dir.
> Those structs serves as caching, right ? It does not modify data format on
> disk ?
> I'm using doxygen and ZFS On-Disk Specification to dig it.
> https://people.freebsd.org/~gibbs/zfs_doxygenation/html/
> dc/d0c/structdsl__dataset.html
>
> benrubson also ask for logical accounting on userquota.
> Modifying zfsvfs struct or adding DMU object will modify data format on
> disk ?
>
zfsvfs_t is only in memory. DMU objects are on disk.
--matt
>
> Any other advices / review about the PR would be very appreciated :)
>
> Thanks by advance,
>
> Florentin Lefebvre
>
> *openzfs-developer* | Archives
> <https://www.listbox.com/member/archive/274414/=now>
> <https://www.listbox.com/member/archive/rss/274414/28015287-49e52ff8> |
> Modify
> <https://www.listbox.com/member/?&;>
> Your Subscription <http://www.listbox.com>
>
-------------------------------------------
openzfs-developer
Archives: https://www.listbox.com/member/archive/274414/=now
RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa
Modify Your Subscription:
https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c
Powered by Listbox: http://www.listbox.com
