Dan Kimmel писал 14.12.2016 21:40:

We've already delivered necessary package. So question was not about this particular change, but about future changes. BTW, have you checked that fio package actually works correctly on illumos?

Sure, we'd also like to improve testing of this in the future too. It
would be helpful if someone replied to @prakashsurya's question about
how we could have caught this. Here is the text of the message he sent
via email:

If there's more testing that we can/should be doing, I'd love to discuss what that is and incorporate it into the automated testing. Currently, what we're doing is pretty simple, and basically consists of: 1. "pkg install" build dependencies (which includes the zfstest package)
2. run the nightly build
3. Use "onu" to install the nightly build products
4. reboot and run tests
The source driving this is open source and on GitHub, so if one wants to know _exactly_ what the steps are, I can give pointers to the relevant code. If we can add a step/test that would have caught the issue, let's talk and see how difficult it'd be to do that in this automation. As Matt said we're using the OmniOS r151020 release with very minimal changes (none related to this). If we need to build/test using OI too, let me know and i'll scope out what's needed to do that. I'm definitely open to making changes to the automation, but I need to better understand the regression so I can know exactly what changes are needed.

Hello.

I think we should test at least also test your changes on OI as we use illumos-gate HEAD and are very sensible to such issues. Also there are some differences (like package naming conversions - we use benchmark/netperf and OmniOS likely system/test/netperf). illumos-gate build options differ between OmniOS and OI, so you likely want to test on both (for example, IIRC, OmniTI doesn't build some printing-related bits).

I'd be glad if building/testing changes on OI was added to automated tests. Let's discuss technical issues, which should be solved to do this.
---
System Administrator of Southern Federal University Computer Center


-------------------------------------------
openzfs-developer
Archives: https://www.listbox.com/member/archive/274414/=now
RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa
Modify Your Subscription: 
https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c
Powered by Listbox: http://www.listbox.com

Reply via email to