hi Brain, i did some update on DilOS for more universal tools/env to use with zfs tests, but with latest updates on OpenZFS tree - they killed my env - i mean: i can’t use my updates now after merges to my separate tree and need time for restore it. my idea was - replace tools PATH by env var like: export SUDO=/usr/bin/sudo or export SUDO=/usr/local/bin/sudo - related to smartos env
with DilOS i have GNU coreutils tools in primary location - at /usr/bin and for ACL tests i’m using tools like chown, chmod, etc - from /system/bin and it was more easy to me - replace PATH for some tools by env vars in shell script where i start zfs tests by Jenkins job. if you are interest - i can provide more details. i think - if we are using zf code on different platforms - will be better to move to use more universal tools and provide solution how to replace tools without tests modifications. i have added OpenZFS maillist to this thread because this problem now visible on ZoL and try to discuss solutions - will be better for adoptation of zfs tests to another platforms. first proposal: move/update zfs tests to use BASH instead of KSH - and yes, it will be big deal, but it will be more universal because more platforms have BASH , but need install KSH as additional shell. I have tested/updated tests for GNU TOOLS: - dd - file - find/grep/sed - and some others if we can find some agreements - we can start to work together with others, wo are interested in run zfs tests on another platfrom. if you are interested in details in DilOS env - let me know. i have no published new ISO and can provide latest snapshot by request. i have more upades with transition to use more flexible build env for ports of userland apps from Debian upstream, but this work still in progress. best regards, -Igor > On Feb 15, 2017, at 1:25 AM, Brian Behlendorf <[email protected]> > wrote: > > So Illumos 7290 <https://www.illumos.org/issues/7290> openzfs/openzfs@1d32ba6 > <https://github.com/openzfs/openzfs/commit/1d32ba663e202c24a5a1f2e5aef83fffb447cb7f> > is the big change to be aware. OpenZFS decided to change the scheme they're > using to locate the binaries to run and updated all of their test cases for > the following reasons: > > It doesn't constrain the set of allowable commands. New tests can always > introduce a utility directly, bypassing the current mechanism. > It leads to errors where $COMMAND is used, but not defined. > A variable referring to a command can be overridden (think export > FILE=/tmp/foo) > We're going to need to decide if we're going to pick up this patch and adopt > the PATH method. I can't remember any of the concerns above being major pain > points for us and it will be fair bit of work to port. But if we don't pull > it in all of our test cases will diverge from the OpenZFS versions making it > difficult to share tests. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/zfsonlinux/zfs/pull/5792#issuecomment-279856109>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AA5Gk-nOViwpPfasGW547zt00a2HBxA_ks5rcinSgaJpZM4MA4gP>. > ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
