Looking at the test failures this seems to fail a lint about an ignored return
value from `nvlist_merge`... would this change satisfy everyone on this thread?
``` diff
diff --git a/usr/src/uts/common/fs/zfs/spa.c b/usr/src/uts/common/fs/zfs/spa.c
index 76e0d2f..c5ab603 100644
--- a/usr/src/uts/common/fs/zfs/spa.c
+++ b/usr/src/uts/common/fs/zfs/spa.c
@@ -6988,7 +6988,8 @@ spa_event_create(spa_t *spa, vdev_t *vd, nvlist_t
*hist_nvl, const char *name)
}
if (hist_nvl != NULL) {
- nvlist_merge((nvlist_t *)attr, hist_nvl, 0);
+ if (nvlist_merge((nvlist_t *)attr, hist_nvl, 0) != 0)
+ goto done;
}
if (sysevent_attach_attributes(ev, attr) != 0)
```
Basically, if `spa_event_create` is called with the `hist_nvl` argument and
fails to merge it in with the sysevent nvlist, just `goto done` - which is the
common routine for all other possible errors in this function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/101#issuecomment-303151927
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Tdfa34f7da75990e1-Mbbb66c287dabd05e50e5e780
Powered by Topicbox: https://topicbox.com
