ahrens approved this pull request.
> @@ -203,6 +204,23 @@ lzc_clone(const char *fsname, const char *origin,
return (error);
}
+int
+lzc_promote(const char *fsname, const char *origin)
Having to specify the origin snapshot is a bit unfortunate (the kernel could
figure it out), so it's not great to encode that in the (hopefully stable) API.
If you wanted to fix that while you're here, it would be great. But I'll go
ahead and approve this as-is; we can always turn "origin" into an unused,
ignored parameter in the future.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/385#pullrequestreview-40086201
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox-beta.com/groups/developer/discussions/Tb321381674e0be00-Mc40b5d8054c5edea3a90fe07
Powered by Topicbox: https://topicbox-beta.com
