grwilson commented on this pull request.
> @@ -6882,10 +6882,10 @@ l2arc_write_buffers(spa_t *spa, l2arc_dev_t *dev,
> uint64_t target_sz)
ASSERT3U(write_asize, <=, target_sz);
ARCSTAT_BUMP(arcstat_l2_writes_sent);
- ARCSTAT_INCR(arcstat_l2_write_bytes, write_asize);
+ ARCSTAT_INCR(arcstat_l2_write_bytes, write_psize);
ARCSTAT_INCR(arcstat_l2_size, write_sz);
my suggestion was to change the arcstat to have more meaning (i.e.
arcstat_l2_lsize) but keep the kstat name the same (i.e. "l2_size"). This
shouldn't break any external consumers and will allow developers to know the
true meaning of this counter.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/310#discussion_r120889674
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Td414270217188b5f-M19eb287c469c417fea274c9b
Powered by Topicbox: https://topicbox.com
