prakashsurya commented on this pull request.
> @@ -3660,7 +3660,7 @@ zfs_promote(zfs_handle_t *zhp)
return (zfs_error(hdl, EZFS_EXISTS, errbuf));
default:
- return (zfs_standard_error(hdl, save_errno, errbuf));
+ return (zfs_standard_error(hdl, ret, errbuf));
@andy-js @ahrens I think this change is needed, in addition to the earlier
changes; right? I see other functions pass in `errno`, but I think that's
incorrect for the same reason that we removed `save_errno` to begin with. Let
me know what you think.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/389#pullrequestreview-43041838
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T3d8522d1a7ad5f47-Mec675daf5366eaf7e740f2c0
Powered by Topicbox: https://topicbox.com
