ahrens commented on this pull request. @ryao Thanks a lot for porting changes from ZoL, I really appreciate your efforts to reduce the differences between ZoL and illumos code.
I'm surprised that this gets much benefit, since we are already avoiding the object number -> dnode lookup, by using the dmu_buf_t. But using the dnode directly does seem cleaner. Let's fix the code duplication and then get this integrated. > @@ -1476,6 +1476,44 @@ dmu_return_arcbuf(arc_buf_t *buf) * dmu_write(). */ void +dmu_assign_arcbuf_dnode(dnode_t *dn, uint64_t offset, arc_buf_t *buf, + dmu_tx_t *tx) This function looks like mostly copy/paste of dmu_assign_arcbuf(). Could you change dmu_assign_arcbuf() to call dmu_assign_arcbuf_dnode(), so that we aren't adding duplicated code? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/403#pullrequestreview-43846944 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tb8c99eb91b584cfa-M708e4b686d42b48b2b92237d Powered by Topicbox: https://topicbox.com
