Thanks for the link @loli10K! The problem was something else: ``` 23:06:48.76 SUCCESS: is_pool_scrub_paused testpool 23:06:50.01 cannot scrub testpool: currently scrubbing; use 'zpool scrub -s' to cancel current scrub ``` So it's the scrub resume that "wasn't working". In fact the resume was working but it was issuing two resume IOCTLs per one scrub pause cmd. The second one would see the restarted scrub and bail with an error. Looks like illumos will re-issue a syscall when it returns ERESTART (probably what the OS should do). I've changed the scrub resume to use ECANCELED instead of ERESTART and it looks to be working as expected now. If the tests look good I'll make the same change in ZoL to keep the code consistent.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/407#issuecomment-310740392 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T693650e65dc896fc-M1c2d438b811de624fe6066f1 Powered by Topicbox: https://topicbox.com
