rmustacc commented on this pull request.
> @@ -2355,6 +2355,18 @@ nvlist_common(nvlist_t *nvl, char *buf, size_t > *buflen, int encoding, } int +nvlist_invalidate(char *buf) Shouldn't this function be taking the size of the buffer in question that we're modifying? I realize that we're only modifying the first byte at this time which in theory should always be valid for a char *, but seems like if this ever changes, that'll be helpful as the function is making an implicit assumption about the size. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/424#pullrequestreview-49803070 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T92ce69bb6bd4a9c6-M5aed2960c23eae7ddd81cff6 Powered by Topicbox: https://topicbox.com
