alek-p approved this pull request.
this is illumos specific and LGTM
> + return (tmp);
+}
+
+/*
+ * Check if given FRUs match by slot number to skip comparing disk specific
+ * fields of the FRU.
+ */
+/* ARGSUSED */
+int
+libzfs_fru_cmp_slot(libzfs_handle_t *hdl, const char *a, const char *b,
+ size_t len)
+{
+ char *slota, *slotb;
+ int ret = -1;
+
+ if (a == NULL || b == NULL)
I believe means that auto replace won't take place on drives, not in an
enclosure or drives inside enclosures that don't report a bay number.
It would be nice to allow autoreplace on non-enclosure devices but that comes
with the risk of screwing up jbod affinity in other use cases so I'm not sure
there is a better way to deal with theses cases...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/416#pullrequestreview-51649863
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T97ec8ed8719a97d0-M2883c363ecd2f7cd6ce140f0
Powered by Topicbox: https://topicbox.com
