Hi @idodeclare, including the lower 8 bits of the spa and many more bits of the os (because we're dropping the lower 8 and then & with 0xFF, so we only get bits 8-15) does not decrease the quality of the hashing. It will not cause any new collisions which did not already occur, and we perform a full equality check to find the appropriate element, so it will not result in incorrect return values.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/423#issuecomment-326756848 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tdd11813c34a59905-Md50aa3f79dd037bc6a873913 Powered by Topicbox: https://topicbox.com
