I was getting this ready for the RTI and I noticed cstyle had some complaints: ``` C style: usr/src/uts/common/fs/zfs/zfs_replay.c: 836: missing space between type name and * usr/src/uts/common/fs/zfs/zfs_replay.c: 836: unary * followed by space usr/src/cmd/zdb/zdb_il.c: 274: missing space between type name and * usr/src/cmd/zdb/zdb_il.c: 282: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 283: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 284: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 285: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 286: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 287: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 288: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 289: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 290: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 291: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 292: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 293: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 294: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 295: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 296: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 297: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 298: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 299: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 300: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 301: missing space around assignment operator usr/src/cmd/zdb/zdb_il.c: 302: missing space around assignment operator usr/src/uts/common/fs/zfs/spa.c: 5870: missing space between type name and * usr/src/cmd/zdb/zdb.h: 28: #define followed by space instead of tab usr/src/cmd/zdb/zdb.h: 33: missing blank after start comment usr/src/cmd/zdb/zdb.c: 1021: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 1022: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 2741: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 2904: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 3209: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 3210: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 3721: missing space between keyword and paren usr/src/cmd/zdb/zdb.c: 3768: missing space between keyword and paren usr/src/lib/libzpool/common/sys/zfs_context.h: 200: line > 80 characters
Header format: usr/src/cmd/zdb/zdb.h: Missing or invalid ending header guard ``` I've pushed a new version of this PR with what I think will address those issues. I'll let this run through the build again, and make sure I made the correct fixes. Let me know if there's any objections to the changes I made. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/354#issuecomment-331304012 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T95949071eb220b14-M42fd5ed4b388dfb61f8e052b Powered by Topicbox: https://topicbox.com
