Perhaps a small knit, maybe not even a knit. I noticed that `int ret = ENOENT;` was added in `usr/src/lib/libzfs/common/libzfs_dataset.c` at line 844, but it does not appear as though this `ret` variable is used consistently. Maybe it should be initialized to `0` (it is reassigned later to `0`, seemingly) and then set accordingly from return of call, like one to `getmntany` at line 854. Would be good I suppose if it was returned consistently, as opposed to being used in some cases.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/451#issuecomment-333868329 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T156a07b986390bdb-M6934fe43ecddd39c0cd49b14 Powered by Topicbox: https://topicbox.com
