Thanks for your time and replies on this, @gwr :) > Maybe a separate PR for the new lib might be easier...
Like this PR? IIRC, this only includes changes related to exposing the taskq code for userspace, so maybe @andy-js is right, and I should just reopen this PR so we can hash out the details of this new library isolated from the ZFS changes. If I do that, am I understanding correctly, that the next steps would be to: 1. Use a new library for this new taskq code, rather than putting it into `libcmdutils`? Naming is hard, so do folks have a recommendation? `libutaskq`? 2. Remove the `system_taskq` interfaces 3. Re-evaluate the "exit on out-of-memory" behavior. From Rob's comments, it sounds like (and I tend to agree) we really should be returning `ENOMEM` (or w/e is appropriate) to the consumer, rather than terminating when hitting an out of memory condition. 4. What about the naming and CTF issue? I don't think I fully understand the concern there. If folks think it's best to start with this PR by itself, I can pick this up after the dev summit next week, and try to get it moving forward again. Since it's a dependency of #451, I think it's worth spending some time to get this moving forward. > I'd like to see how it goes replacing the one in libfakekernel with it. Honestly, I didn't even realize there was already a taskq implementation in `libfakekernel`. Now I'm curious what the differences are between what's being done here, and what already exists in `libfakekernel`. I presume, we'd want to merge the two implementations, right? (assuming what's already in `libfakekernel` isn't sufficient for #451). I'll ask around internally in Delphix and try to get a better understanding of why we didn't just use `libfakekernel`'s taskq to begin with. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/141#issuecomment-338269143 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T012acd019d09e76d-M359b5e2f284fbe54a5e84750 Powered by Topicbox: https://topicbox.com
