ahrens commented on this pull request.
> @@ -5395,8 +5395,13 @@ print_holds(boolean_t scripted, size_t nwidth, size_t
> tagwidth, nvlist_t *nvl)
(void) strftime(tsbuf, DATETIME_BUF_LEN,
gettext(STRFTIME_FMT_STR), &t);
- (void) printf("%-*s%*c%-*s%*c%s\n", nwidth, zname,
- sepnum, sep, tagwidth, tagname, sepnum, sep, tsbuf);
+ if (scripted)
+ (void) printf("%s%c%s%c%s\n", zname,
+ sep, tagname, sep, tsbuf);
+ else
+ (void) printf("%-*s%*c%-*s%*c%s\n", nwidth,
+ zname, sepnum, sep, tagwidth, tagname,
+ sepnum, sep, tsbuf);
The printf's would be simpler if we used ` ` / `\t` in the format string,
rather than using the variable `sep`.
For readability, cstyle recommends {braces} around multi-line if/else bodies
(even if only one statement).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/488#pullrequestreview-73526581
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Tb89fa1a435032eb4-Ma5a2d3fbe4b5caab414a73bd
Powered by Topicbox: https://topicbox.com
