Is anyone interested in reviewing this new ZFS feature, which also substantially *refactors the ZFS send/receive code*? It's a big change (>12,000 LOC, more than half of which is in kernel .c's), so I understand if folks don't want to look at every line, but it wouldn't hurt if someone outside Delphix could give us a thumbs up on the overall design. After the slides <https://drive.google.com/file/d/0B4BF1vnv6p0-cHZEeEJaZmNpZVE/view> and 4-minute video <https://youtu.be/LaNgoAZeTww?t=15m31s>, a good place to start with the code would be the manpage changes <https://github.com/openzfs/openzfs/pull/484/files#diff-b138320fc5f9d5c48bb4b03a5e4e4cbbR2912> and the comment above dmu_send_impl <https://github.com/openzfs/openzfs/pull/484/files#diff-b3787d3eecd97aa98f0e49d2975c0d5fR1867> ().
The PR against OpenZFS/illumos <https://github.com/openzfs/openzfs/pull/484> has been open for 20 days with no feedback. We believe it's ready to integrated. If we don't hear any negative feedback, *we'll RTI this sometime in December*. Several Delphix engineers have done extensive code reviews on this, and our customers have been using in in production for over a year. https://github.com/openzfs/openzfs/pull/484 Short description: This patch implements Redacted send/recv, a feature for zfs send and receive described at the 2015 ZFS developer summit. It includes extensive testing, as well as significant refactoring of the ZFS send and receive code. Also included are new features for send size estimation, new ioctls for accessing bookmark properties, and new zdb features to access bookmarks directly. It also updates featureflags to be typed instead of untyped, allowing more useful feature information to be stored directly. Slides from 2015 talk (Redacted send/recv starts around slide 19): https://drive.google.com/file/d/0B4BF1vnv6p0-cHZEeEJaZmNpZVE/view Video from 2015 talk (only 4 minutes on redaction!): https://youtu.be/LaNgoAZeTww?t=15m31s Thanks! --Matt and Paul ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Td915fa657c9fbda8-M48e6238477f6b6ba80fa166a Powered by Topicbox: https://topicbox.com
