pcd1193182 commented on this pull request.
> + */
+static int
+find_redact_book(libzfs_handle_t *hdl, const char *path,
+ const uint64_t *redact_snap_guids, int num_redact_snaps,
+ char **bookname)
+{
+ char errbuf[1024];
+ int error = 0;
+ nvlist_t *props = fnvlist_alloc();
+ nvlist_t *bmarks;
+
+ (void) snprintf(errbuf, sizeof (errbuf), dgettext(TEXT_DOMAIN,
+ "cannot resume send"));
+
+ fnvlist_add_boolean(props, "redact_complete");
+ fnvlist_add_boolean(props, "redact_snaps");
It's normal, in libzfs, to use the literal string value instead of getting it
with zfs_prop_to_name. I went with this approach for consistency (and
compactness, as a fringe benefit), but I don't feel strongly about using it
instead of getting the name through a function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/484#discussion_r152372643
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T1fcfd4fc81bcdfff-M6a3f3010c0a8e508faba14da
Powered by Topicbox: https://topicbox.com
