gwr commented on this pull request.
The rest looks reasonable, but let's chat about what to keep in libfakekernel
vs. consumers.
> + *
+ * CDDL HEADER END
+ */
+/*
+ * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2015 by Delphix. All rights reserved.
+ * Copyright (c) 2013, Joyent, Inc. All rights reserved.
+ * Copyright 2017 RackTop Systems.
+ */
+
+#include <sys/debug.h>
+#include <sys/buf.h>
+#include <sys/errno.h>
+
+#include <strings.h>
+
Is this file sufficiently "generic" that it deserves to be part of
libfakekernel? or should it remain as part of libzpool?
> @@ -52,6 +53,34 @@ crgetuid(const cred_t *cr)
return (0);
}
+/*ARGSUSED*/
I'm not sure we should keep the cred stuff in libfakekernel.
Maybe better to leave that to the consumers?
(libfksmbsrv, and libzpool after this work)
> @@ -65,6 +67,29 @@ kmem_zalloc(size_t size, int kmflags)
return (umem_zalloc(size, kmem2umem_flags(kmflags)));
}
+/*
How about adding a strext.c file for this?
(like in uts/common/os)
It might not have been obvious, but we tried to keep the functions organized in
files of similar names as the "real" versions.
> @@ -69,6 +117,32 @@ delay(clock_t ticks)
(void) poll(0, 0, msec);
}
+int
+issig(int why)
+{
+ return (0);
+}
+
+/* ARGSUSED */
Here too, how about a cyclic.c?
Would rather not see kmisc.c turn into more of a "catch" all...
> @@ -0,0 +1,68 @@
+/*
Doesn't this clash with what libfksmbsrv is doing with creds, sids, and ksids?
I think we may need to keep this too in the consumers, rather than in
libfakekernel (leaving this ignorant of creds or ksids).
> @@ -0,0 +1,80 @@
+/*
Did you run into problems using the normal sys/cmn_err.h?
What happened?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/494#pullrequestreview-80691511
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T34088d4e3e9cd4f5-M745bcb2edae84659b21ba1ff
Powered by Topicbox: https://topicbox.com
