ahrens commented on this pull request.
> @@ -1549,6 +1549,8 @@ arc_cksum_is_equal(arc_buf_hdr_t *hdr, zio_t *zio)
void *cbuf = zio_buf_alloc(HDR_GET_PSIZE(hdr));
csize = zio_compress_data(compress, zio->io_abd, cbuf, lsize);
+ abd_t *cdata = abd_get_from_buf(cbuf, HDR_GET_PSIZE(hdr));
+ abd_take_ownership_of_buf(cdata, B_TRUE);
Is this effectively doing the same thing as:
```
abd_t *cdata = abd_alloc_linear(HDR_GET_PSIZE(hdr), B_TRUE)
zio_compress_data(... abd_to_buf(cdata) ...)
```
If so, let's simplify it to that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/498#pullrequestreview-84839497
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Te84e226aa4103950-Mf3cd6432b22560b53fc9f36a
Powered by Topicbox: https://topicbox.com
