@ahrens If we're using the Linux kernel contributor sign-off definitions, I'm okay with Acked-by, but I think Reviewed-by would overstate the amount of review I have given it (or even could give it, given my lack of kernel and ZFS-internals knowledge). However, if it is normal practice in OpenZFS to convert "looks good to me" to "Reviewed by", then I'm absolutely okay with that.
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/482#issuecomment-353487184 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Teafc5ffabd7f916f-Mc91cd1da7715ff4305906ee2 Powered by Topicbox: https://topicbox.com
