avg-I commented on this pull request.
> ASSERT(!dsl_pool_sync_context(tx->tx_pool));
/* If we might wait, we must not hold the config lock. */
- ASSERT(txg_how != TXG_WAIT || !dsl_pool_config_held(tx->tx_pool));
+ ASSERT((txg_how & TXG_WAIT) || !dsl_pool_config_held(tx->tx_pool));
I think that the first part of the condition is inverted here.
It probably would make sense to use `IMPLY` here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/514#pullrequestreview-88167949
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T9a006f4f91609eb5-M320227e0ed5a7418cda40c95
Powered by Topicbox: https://topicbox.com
