@prakashsurya To explicitly confirm: Is 
https://github.com/openzfs/openzfs/commit/f539f1eb707e3af0ec4617c664b67dff46a0c173
 closing #482 or #251? 

Descriptions differ slightly with regards to support for removal of mirror 
devices...

Commit:

> Note that when a device is removed, we do not verify the checksum of the
> data that is copied.  This makes the process much faster, but if it were
> used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
> possible to copy the wrong data, when we have the correct data on e.g.
> the other side of the mirror.  Therefore, mirror and raidz devices can
> not be removed.

#482:

> Note that when a device is removed, we do not verify the checksum of the
> data that is copied. This makes the process much faster, but if it were
> used on raidz vdevs, it would be possible to copy the wrong data,
> when we have the correct data on e.g. the other side of the raidz.
> Therefore, raidz devices can not be removed.

#251: 

> Note that when a device is removed, we do not verify the checksum of the
> data that is copied. This makes the process much faster, but if it were
> used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
> possible to copy the wrong data, when we have the correct data on e.g.
> the other side of the mirror. Therefore, mirror and raidz devices can
> not be removed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/482#issuecomment-360989047
------------------------------------------
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T99d5989ffc14739b-Mc3f2a45a2b3e8d0964ad424f
Powered by Topicbox: https://topicbox.com

Reply via email to