martymac commented on this pull request.
> @@ -709,8 +751,12 @@ zpool_do_labelclear(int argc, char **argv)
}
if (zpool_read_label(fd, &config) != 0) {
- (void) fprintf(stderr,
- gettext("failed to read label from %s\n"), vdev);
+ if (force)
Hi George,
The original version of FreeBSD's labelclear command allowed to forcibly wipe a
label in any case (except when a pool is in use), see :
https://svnweb.freebsd.org/base?view=revision&revision=224171
but that "feature" disappeared when the labelclear command was imported from
upstream :
https://svnweb.freebsd.org/base?view=revision&revision=297760
So this is just a fix to re-add that possibility : if we really want to force a
wipe out, I think the command should not prevent us from doing so ; and that
becomes even more useful when working with individual labels, as that patch now
allows.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/424#discussion_r166851668
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T59e810f5492df392-M96bfa58c87dac44031872719
Powered by Topicbox: https://topicbox.com
