andy-js commented on this pull request.
Overall looks good.
> +#
+# We want to test the case where a whole created by a log device is filled
+# by a regular device
+#
+function test_remove_log_then_add_vdev
+{
+ log_note "$0."
+ log_must zpool create -o cachefile=$CPATH $TESTPOOL1 \
+ $VDEV0 $VDEV1 $VDEV2 log $VDEV3
+
+ log_must cp $CPATH $CPATHBKP
+
+ log_must zpool remove $TESTPOOL1 $VDEV1
+ log_must wait_for_pool_config $TESTPOOL1 "$VDEV0 $VDEV2 log $VDEV3"
+ log_must zpool remove $TESTPOOL1 $VDEV3
+ log_must check_pool_config $TESTPOOL1 "$VDEV0 $VDEV2"
The indentation looks wonky here.
> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
}
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)
I think this probably belongs in libfakekernel.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/539#pullrequestreview-95153387
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/T603f896faeeb4d25-Mf1cc508ea5824637283cc241
Powered by Topicbox: https://topicbox.com
