andy-js commented on this pull request.
> @@ -1716,15 +1731,18 @@ zfs_acl_ids_create(znode_t *dzp, int flag, vattr_t
> *vap, cred_t *cr,
mutex_exit(&dzp->z_lock);
mutex_exit(&dzp->z_acl_lock);
- if (vap->va_type == VDIR)
- acl_ids->z_aclp->z_hints |= ZFS_ACL_AUTO_INHERIT;
-
- if (zfsvfs->z_acl_mode == ZFS_ACL_GROUPMASK &&
- zfsvfs->z_acl_inherit != ZFS_ACL_PASSTHROUGH &&
- zfsvfs->z_acl_inherit != ZFS_ACL_PASSTHROUGH_X)
- trim = B_TRUE;
- zfs_acl_chmod(vap->va_type, acl_ids->z_mode, B_FALSE, trim,
- acl_ids->z_aclp);
+ if (need_chmod) {
How would you feel about adding a tuneable to make this unconditional?
Something like zfs_acl_always_chmod maybe.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/557#pullrequestreview-97613261
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Taa24d3ad3ace2410-Meb8fce46431299c0fbde7141
Powered by Topicbox: https://topicbox.com
