ahrens commented on this pull request.
> +out: + /* + * Note, indirect vdevs don't handle a few important cases for split + * blocks when one side of a mirror is silently corrupt: + * + * When we read bad data and then retry the other side of the mirror, + * we should issue a repair write to fix the bad copy. + * + * When scrubbing, we should read all copies of the data (and + * repair any bad copies). + * + * We should generate ereports for any data we read with the wrong + * checksums. + */ + + zio_checksum_verified(zio); Since we've already verified that the checksum is wrong, and set `io_error` appropriately, there isn't any point to doing it again, which is what calling zio_checksum_verified() accomplishes. This is similar to what happens near the end of `vdev_raidz_io_done()`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/561#discussion_r169849398 ------------------------------------------ openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T05e845542b9791ed-M21429f8b9f05adb3faca4503 Powered by Topicbox: https://topicbox.com
