tcaputi approved this pull request. This patch looks good and all the edge cases I could think of are handled appropriately (zfs upgrade, etc). As a minor convenience, I would want a way to determine how much memory my metadata cache is using (in ZoL we would make this a read-only tunable, maybe you can already see this in Illumos with your debugging tools).
I would also be interested to know what the limiting performance factor is after applying this diff. 51 seconds still seems like a long time when all the data is already in memory. This, however, is not really a concern for this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#pullrequestreview-106650144 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-M52593237719a1891e9e13fe9 Delivery options: https://openzfs.topicbox.com/groups
